Skip to content

Dev: update setup #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Dev: update setup #37

merged 1 commit into from
Apr 5, 2025

Conversation

blocknotes
Copy link
Owner

@blocknotes blocknotes commented Apr 5, 2025

🔧 Improve Dev setup

  • All Dev files (but Makefile) are placed in the extra/ folder
  • Minor internal improvement to the Dev setup

@blocknotes blocknotes self-assigned this Apr 5, 2025
@blocknotes blocknotes marked this pull request as ready for review April 5, 2025 09:22
@blocknotes blocknotes requested a review from Copilot April 5, 2025 09:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 8 changed files in this pull request and generated 1 comment.

Files not reviewed (6)
  • .dockerignore: Language not supported
  • Makefile: Language not supported
  • extra/Dockerfile: Language not supported
  • extra/Dockerfile.dockerignore: Language not supported
  • extra/dev_setup.sh: Language not supported
  • extra/init.sh: Language not supported
Comments suppressed due to low confidence (1)

extra/docker-compose.yml:19

  • The removal of the custom command may result in the container not running the intended initialization script if a default command is not set in the image. Please confirm that the image defines a proper default command or consider an alternative method to provide the initialization behavior.
-    command: ${COMMAND:-extra/init.sh}

@blocknotes blocknotes requested a review from Copilot April 5, 2025 09:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • .dockerignore: Language not supported
  • Makefile: Language not supported
  • extra/Dockerfile: Language not supported
  • extra/Dockerfile.dockerignore: Language not supported
  • extra/dev_setup.sh: Language not supported
  • extra/init.sh: Language not supported
Comments suppressed due to low confidence (1)

extra/docker-compose.yml:19

  • Removing the command line may lead to containers starting without the intended initialization script. Please verify that an appropriate default command is now set elsewhere or that this removal is intentional.
command: ${COMMAND:-extra/init.sh}

@blocknotes blocknotes merged commit b5e51dc into main Apr 5, 2025
10 checks passed
@blocknotes blocknotes deleted the dev/update-setup branch April 5, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant